Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update /concepts/nodes page #1624

Merged
merged 7 commits into from
Jun 29, 2023
Merged

feat: update /concepts/nodes page #1624

merged 7 commits into from
Jun 29, 2023

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Jun 14, 2023 •
edited
Loading

  • feat: update /concepts/nodes page

Describe your changes

Files changed

  • docs/concepts/nodes.md

What issue(s) does this address?

Part of #1611

Does this update depend on any other PRs?

Checklist before requesting a review

  • Passing the beta version of the Check Markdown links for modified files check. Action results can be viewed here.

Checklist before merging

  • Passing all required checks (The beta Check Markdown links for modified files check is not required)

@SgtPooki SgtPooki changed the base branch from main to js-ipfs-cleanup June 14, 2023 23:41
SgtPooki
SgtPooki commented Jun 14, 2023
View reviewed changes
docs/concepts/nodes.md Outdated Show resolved Hide resolved
SgtPooki
SgtPooki commented Jun 14, 2023
View reviewed changes
docs/concepts/nodes.md Outdated Show resolved Hide resolved
lidel
lidel reviewed Jun 15, 2023
View reviewed changes
docs/concepts/nodes.md Show resolved Hide resolved
docs/concepts/nodes.md Outdated Show resolved Hide resolved
docs/concepts/nodes.md Outdated Show resolved Hide resolved
ElPaisano
ElPaisano reviewed Jun 28, 2023
View reviewed changes
docs/concepts/nodes.md Outdated Show resolved Hide resolved
@ElPaisano
Copy link
Contributor

@SgtPooki are there any other changes you'd like to make before I merge this into https://github.com/ipfs/ipfs-docs/tree/js-ipfs-cleanup for final cleanup and merging?

@SgtPooki
Copy link
Member Author

@SgtPooki are there any other changes you'd like to make before I merge this into https://github.com/ipfs/ipfs-docs/tree/js-ipfs-cleanup for final cleanup and merging?

Theres a few items left. Let me handle those and update you. Gimme a few

@SgtPooki
Copy link
Member Author

@ElPaisano seems like we should be ready to go now. It was only the relay v1 task that was left.

@ElPaisano ElPaisano merged commit 18e8d00 into js-ipfs-cleanup Jun 29, 2023
@ElPaisano ElPaisano deleted the js-ipfs-cleanup__concepts/nodes branch June 29, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel left review comments

@ElPaisano ElPaisano ElPaisano left review comments

@achingbrain achingbrain Awaiting requested review from achingbrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SgtPooki @ElPaisano @lidel